[PATCH] D143207: Add codegen for llvm log2/log10 elementwise builtins

[Florian Hahn via Phabricator via cfe-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: jobnoorman.

LGTM, thanks! Looks like a straight-forward extension of the existing builtins.



================
Comment at: clang/test/Sema/aarch64-sve-vector-log-ops.c:17
+  return __builtin_elementwise_log10(v);
+  // expected-error at -1 {{1st argument must be a vector, integer or floating point type}}
+}
----------------
We should ideally not mention `integer type` here. Not directly related to the patch, but would be great to see this fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143207/new/

https://reviews.llvm.org/D143207