[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 6 17:14:56 PST 2023


jansvoboda11 added inline comments.


================
Comment at: clang/lib/Basic/FileManager.cpp:624
+      // file entry.
+      if (Value->V.dyn_cast<FileEntry *>())
+        Entries.push_back(FileEntryRef(Entry));
----------------
Nit: I think `dyn_cast()` could be replaced by `is()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143414/new/

https://reviews.llvm.org/D143414



More information about the cfe-commits mailing list