[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

Mike Rice via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 6 10:49:00 PST 2023


mikerice added inline comments.


================
Comment at: clang/test/PCH/delayed-template-with-pragma-pack.cpp:14
+int func() {
+#pragma pack(push, 1)
+  struct s { short a; T b; };
----------------
Your test should include testing of the slot string too, so we are sure all fields are serialized and restored correctly. Otherwise this looks reasonable to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143410/new/

https://reviews.llvm.org/D143410



More information about the cfe-commits mailing list