[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 6 10:37:32 PST 2023


nickdesaulniers added inline comments.


================
Comment at: clang/test/CodeGen/init-randomized-struct-fwd-decl.c:2
+// RUN: %clang_cc1 -triple=x86_64-unknown-linux -emit-llvm -frandomize-layout-seed=1234567890abcdef < %s | FileCheck %s
+// RUN: %clang_cc1 -triple=x86_64-unknown-linux -emit-llvm -frandomize-layout-seed=1234567890abcdef -DFORWARD_DECL < %s | FileCheck -check-prefix=FWD-DECL %s
+// PR60349
----------------
Is the second check prefix necessary? The check lines look the same to me, unless I'm missing something.

Removing it should let us also drop the redundant FWD-DECL lines below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143300/new/

https://reviews.llvm.org/D143300



More information about the cfe-commits mailing list