[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

[Bill Wendling via Phabricator via cfe-commits]

void added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:18891
+        // incomplete definition.
+        if (const auto *RD = dyn_cast<RecordDecl>(D))
+          return !RD->isCompleteDefinition();
----------------
nickdesaulniers wrote:
> what about `EnumDecl`s? I suspect the shared common base `TagDecl` might be better to use?
> 
> If it is, can you add a test?  I'm guessing
> 
> ```
> struct foo {
>   enum havent_seen_yet;
>   enum havent_seen_yet2;
> }
> ```
> would be the test case.
Would testing for a `TagDecl` be better here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143300/new/

https://reviews.llvm.org/D143300