[PATCH] D143386: Add function pointer alignment to DataLayout
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 6 09:12:37 PST 2023
efriedma added a comment.
Almost all the specifications you're specifying are wrong. Very few targets should be using "i". Off the top of my head, 32-bit ARM, MIPS targets with MicroMIPS, and certain PowerPC targets should, but most common targets shouldn't. ("i" means that either the target mangles the bottom bits of function pointers, or function pointers don't point directly at code.) And the x86 doesn't specify 4-byte alignment.
For each target, we should try to handle the LLVM backend at the same time...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143386/new/
https://reviews.llvm.org/D143386
More information about the cfe-commits
mailing list