[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

Mon Feb 6 05:01:40 PST 2023

kadircet added a comment.

thanks a lot. since this is the last (and only) upstream user of the raw mappings. can you also move them into `clang/lib/Tooling/Inclusions/Stdlib/` as part of this patch?

================
Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:43
+  /// Returns the overridden include for a qualified symbol with, or "".
+  llvm::StringRef mapSymbol(llvm::StringRef /*std::*/ Scope,
+                            llvm::StringRef /*vector*/ Name,
----------------
these parameter comments are a little bit unconventional, maybe just mention that `Scope` should have trailing colons (e.g. std::) and name shouldn't have any (e.g. vector) ? also mention that `it should be empty ("") for global namespace`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143274/new/

https://reviews.llvm.org/D143274