[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

Mon Feb 6 04:16:20 PST 2023

hokein added inline comments.

================
Comment at: clang/include/clang/Tooling/Inclusions/StdAlternativeHeaderMap.inc:3
+//
+// This is a hand-curated list for C++ symbols (e.g. provided by multiple
+// headers), to address the short comings of cppreference or automated
----------------
kadircet wrote:
> `This is a hand-curated list for C++ symbols` reads like we're planning to put all special C++ symbols into this file, rather than just the ones that are provided by alternative headers. that's the reason why i mentioned it as `This is a hand-curated list for symbols provided by multiple headers` specifically.
Restricting the file only to multiple-header symbols seems a bit narrow (and the `consume_header` symbol only has one header which doesn't fit into this bucket nicely).

My take of this file is - we'll put all special C++ symbols that are not able to handle by the cppreference generator, multiple-header symbols are the most critical ones.

What do you think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143160/new/

https://reviews.llvm.org/D143160