[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:736
 void CanonicalIncludes::addSystemHeadersMapping(const LangOptions &Language) {
   if (Language.CPlusPlus) {
+    static const auto *Symbols = []() {
----------------
kadircet wrote:
> what about getting rid of `StdSymbolMapping` completely and changing `CanonicalIncludes::mapSymbol` to use `tooling::stdlib` ?
> only call site is through `SymbolCollector`, which has access to `LangOptions`.
Yeah, good idea. This simplifies the code further, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143274/new/

https://reviews.llvm.org/D143274