[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 6 01:21:16 PST 2023
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:736
void CanonicalIncludes::addSystemHeadersMapping(const LangOptions &Language) {
if (Language.CPlusPlus) {
+ static const auto *Symbols = []() {
----------------
what about getting rid of `StdSymbolMapping` completely and changing `CanonicalIncludes::mapSymbol` to use `tooling::stdlib` ?
only call site is through `SymbolCollector`, which has access to `LangOptions`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143274/new/
https://reviews.llvm.org/D143274
More information about the cfe-commits
mailing list