[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 6 00:34:33 PST 2023


kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:1047
 
+  bool TraverseTypeConstraint(const TypeConstraint *TC) {
+    Out(ReferenceLoc{TC->getNestedNameSpecifierLoc(),
----------------
can you also add a comment like `// We actually want to handle all ConceptReferences but RAV doesn't traverse it polymorphically. So handle the ones inside TypeConstraints specially here.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142871/new/

https://reviews.llvm.org/D142871



More information about the cfe-commits mailing list