[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

[NAKAMURA Takumi via Phabricator via cfe-commits]

chapuni added a comment.

@RKSimon
Could you cherry-pick it?
https://github.com/chapuni/llvm-project/commit/2c09237d8759bb6b1e99940e78901bde5b2bb98f

As a position to reduce overhead in tblgen, I don't agree to move this to LLVMDemangle.
LLVMSupport depends on LLVMDemangle. llvm-tblgen depends on them.

Besides, does this depend on LLVMSupport if you would move this to LLVMDemangle?

I think this is one of practical resolutions. One concern, "Does it make sense if llvm-cxxmap depends on LLVMProfile?"

@MaskRay
Fair enough, even if its user is only LLVMProfileData in the trunk.
That said, in fact, ItaniumManglingCanonicalizerTest.cpp spends the most time to build in LLVMSupport.

I don't have a strong opinion for this to move to LLVMProfileData.
Could we introduce another library, like "LLVMMangleSupport" ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143318/new/

https://reviews.llvm.org/D143318