[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Feb 4 06:45:52 PST 2023


cor3ntin added a comment.

My question is, why do we need to mess up with scopes in that way outside of parsing  (there are only a couple places where we do that at the moment, and they are dummy scopes which only exist to balance some push and pop, afaict they serve no other purpose).
As i said, I have no objection to this at all, it clearly fixes the issue and we should land it! But the fact we have to do this in the first place *may* be a sign that there is a deeper issue, one that we clearly should not try to address as part of this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143109/new/

https://reviews.llvm.org/D143109



More information about the cfe-commits mailing list