[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 3 09:40:56 PST 2023


tbaeder marked 2 inline comments as done.
tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:34-35
 
+  virtual ~DeclScope() override { this->emitDestruction(); }
+
   void addExtended(const Scope::Local &Local) override {
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > The destructor for `LocalScope` already calls `emitDestruction()` which is a virtual function, so is this necessary?
> Still wondering about this
You're right, removed it again. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138802/new/

https://reviews.llvm.org/D138802



More information about the cfe-commits mailing list