[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 3 08:56:12 PST 2023


aaron.ballman added a comment.

In D124351#4102818 <https://reviews.llvm.org/D124351#4102818>, @rupprecht wrote:

> In D124351#4102679 <https://reviews.llvm.org/D124351#4102679>, @aaron.ballman wrote:
>
>> In D124351#4102634 <https://reviews.llvm.org/D124351#4102634>, @eaeltsin wrote:
>>
>>>> Looks like we fail to enter the appropriate context somewhere (my guess is that it might be specific to the attribute but it's hard to say without picking around), definitely a bug
>>>>
>>>> I'll be away the next 2 weeks, I'll look at it when I get back. Maybe we should track it in an issue though.
>>>
>>> Should we revert this then?
>>
>> Yes, I think we should. We should also file an issue so @cor3ntin doesn't lose track of the issue. Anyone want to volunteer to do that? (I can do it early next week otherwise.)
>
> Done in 74ce297045bac4bc475b8e762d2a1ea19bb16d3c <https://reviews.llvm.org/rG74ce297045bac4bc475b8e762d2a1ea19bb16d3c> and filed https://github.com/llvm/llvm-project/issues/60518 to track re-landing this.

Thank you (and thank you for letting us know about the issue)!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124351/new/

https://reviews.llvm.org/D124351



More information about the cfe-commits mailing list