[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 3 08:37:40 PST 2023


balazske added a comment.

I looked at some of the failing tests but can not decide how to fix the problems. The problem seems to be with the extra `namespace std` that was not there before. I do not know what the tests are exactly testing. A part of the tests can be fixed by adding new expect lines but these must be platform specific.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/dcl58-cpp.cpp:3
+// RUN: %check_clang_tidy -std=c++17-or-later %s cert-dcl58-cpp %t -- -- -I %clang_tidy_headers -target aarch64
+// RUN: %check_clang_tidy -std=c++17-or-later %s cert-dcl58-cpp %t -- -- -I %clang_tidy_headers -target arm
+
----------------
I am not sure if these platform specific should be added. A problem was discovered on this platform but this could be true for all other tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142822/new/

https://reviews.llvm.org/D142822



More information about the cfe-commits mailing list