[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

I'm reasonably happy here.  I think the chained-comparisons getting the && suggestion is nice.  However in each case, the diagnostic is REALLY poor.  It isn't really clear to most folks (barely clear to me!) that `'<' within '>'` really means anything.  I'd love if we could spend some time brainstorming some better diagnostic wording that makes it clear what the problem is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142800/new/

https://reviews.llvm.org/D142800