[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

Jacob Young via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 2 17:05:48 PST 2023


jacobly created this revision.
Herald added a project: All.
jacobly requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

With the Microsoft ABI, some destructors need to offset a parameter to
get the derived this pointer, in which case the type of that parameter
should not be a pointer to the derived type.

Fixes #60465


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143233

Files:
  clang/lib/CodeGen/CGCXXABI.h
  clang/lib/CodeGen/CGCall.cpp
  clang/lib/CodeGen/CGExprCXX.cpp
  clang/lib/CodeGen/MicrosoftCXXABI.cpp
  clang/test/CodeGenCXX/constructor-destructor-return-this.cpp
  clang/test/CodeGenCXX/cxx2a-destroying-delete.cpp
  clang/test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp
  clang/test/CodeGenCXX/microsoft-abi-structors.cpp
  clang/test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143233.494475.patch
Type: text/x-patch
Size: 17211 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230203/78b749f7/attachment-0001.bin>


More information about the cfe-commits mailing list