[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1374
+    : Error<"expected '%0' clause with an argument on '#pragma omp %1' "
+            "construct since OpenMP %2">;
 def err_expected_end_declare_target_or_variant : Error<
----------------
We do not use OpenMP versions in messages.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:17665-17666
                                           SourceLocation EndLoc) {
+  if (!InteropVar && (LangOpts.OpenMP >= 52 &&
+                      DSAStack->getCurrentDirective() == OMPD_depobj)) {
+    Diag(StartLoc,
----------------
You can drop some parens inside condition


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143021/new/

https://reviews.llvm.org/D143021