[PATCH] D142534: Fix emission of consteval constructor of derived type

Thu Feb 2 12:03:50 PST 2023

aaron.ballman added reviewers: efriedma, rjmccall, erichkeane.
aaron.ballman added a comment.

In D142534#4080007 <https://reviews.llvm.org/D142534#4080007>, @Fznamznon wrote:

> In D142534#4079958 <https://reviews.llvm.org/D142534#4079958>, @shafik wrote:
>
>> I think having a link to the github issue in the summary allows for the issue be closed automatically when you commit. Is this correct @aaron.ballman I have been doing this for a while and they get closed when I commit but maybe there is another mechanism involved.
>
> This works at least for GitHub pull requests, see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue . We've been using this in a downstream project. I was hoping it works in the same way for commits, so added issue ID to a commit message.

Yes, this works the same way for commits here. I learned recently that folks appreciate a full link to the issue (`Fixes https://github.com/llvm/llvm-project/issues/NNNN`) instead of `Fixes #NNNN` because it makes it easier to traverse from the commit message to the github issue (and it will still automatically close the issue on commit), so you might consider changing that when you land the patch.

The changes look correct to me, but codegen is not my area of expertise, so adding some other codegen reviewers to double-check.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142534/new/

https://reviews.llvm.org/D142534