[PATCH] D143093: [clangd] #undef macros inside preamble patch

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

I can't understand from the description, code, or testcases what problem this is fixing. Can you clarify, ideally by improving the testcases?

It seems to introduce a false negative in the case that the preamble *does* contain a definition of an already-defined macro, which probably needs to be called out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143093/new/

https://reviews.llvm.org/D143093