[PATCH] D142388: [clang] Add builtin_nondeterministic_value

Thu Feb 2 06:12:34 PST 2023

erichkeane added a comment.

In D142388#4099374 <https://reviews.llvm.org/D142388#4099374>, @ManuelJBrito wrote:

> So this is getting some build failures:
>
> - https://lab.llvm.org/buildbot#builders/38/builds/9446
> - https://lab.llvm.org/buildbot#builders/245/builds/4189
> - https://lab.llvm.org/buildbot#builders/65/builds/7949
> - https://lab.llvm.org/buildbot#builders/188/builds/25538
>
> I suspect it's because of the way different ABIs handle the vectors.  I was thinking that if we have the variable be a local variable and also not returning the value can fix the tests.
>
> Does this make sense?

Yep, thats what it looks like, ABI differences.  Feel free to update this review with the new test now that you've been reverted, and I'll look to see if it seems sufficient.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142388/new/

https://reviews.llvm.org/D142388