[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

Kyle Edwards via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 2 05:38:00 PST 2023


KyleFromKitware added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:493-494
 
 /// Returns the pointer that points to the beginning of line that contains
 /// the given offset, or null if the offset if invalid.
+const char *Lexer::findBeginningOfLine(StringRef Buffer, unsigned Offset) {
----------------
cor3ntin wrote:
> Should we remove the comment here?
Other `Lexer` methods follow a similar pattern of having doc comments both in the header and in the implementation. I think we can leave it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143099/new/

https://reviews.llvm.org/D143099



More information about the cfe-commits mailing list