[PATCH] D142933: Add -print-multi-selection-flags argument
Michael Platings via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 1 12:22:04 PST 2023
michaelplatings added a comment.
> The main trouble I had was at that point we don't have a reference to the ToolChain, so calling `getMultiSelectionFlags` was not possible. [...] I'm not sure what the solution here is.
I see two options:
1. Split getMultiSelectionFlags into needs-ToolChain and doesn't-need-ToolChain parts, with the former calling the latter. From Gnu.cpp, call the latter, with the limitation that it can use fewer flags.
2. Pass a ToolChain to the Gnu.cpp functions.
> I added the arch extensions and abi to the Result in `getMultiSelectionFlags`
What was the syntax you used for that?
I'm not super keen on the `march=+ext` syntax I came up with so I'm open to alternatives.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142933/new/
https://reviews.llvm.org/D142933
More information about the cfe-commits
mailing list