[PATCH] D143094: [clang] Change AMX macros to match names from GCC

Joe Loser via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 1 10:34:44 PST 2023


jloser created this revision.
jloser added reviewers: yubing, LuoYuanke, pengfei, craig.topper.
Herald added a project: All.
jloser requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The current behavior for AMX macros is:

  gcc -march=native -dM -E - < /dev/null | grep TILE
  
  clang -march=native -dM -E - < /dev/null | grep TILE

which is not ideal.  Change `__AMXTILE__` and friends to `__AMX_TILE__` (i.e.
have an underscore in them).  This makes GCC and Clang agree on the naming of
these AMX macros to simplify downstream user code.

Fix this for `__AMXTILE__`, `__AMX_INT8__`, `__AMX_BF16__`, and `__AMX_FP16__`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143094

Files:
  clang/lib/Basic/Targets/X86.cpp
  clang/lib/Headers/immintrin.h
  clang/test/Preprocessor/predefined-arch-macros.c
  clang/test/Preprocessor/x86_amx_target_features.c
  clang/test/Preprocessor/x86_target_features.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143094.494005.patch
Type: text/x-patch
Size: 7507 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230201/112c839b/attachment.bin>


More information about the cfe-commits mailing list