[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

Wed Feb 1 09:56:08 PST 2023

dblaikie added a comment.

In D124351#4097110 <https://reviews.llvm.org/D124351#4097110>, @cor3ntin wrote:

> In D124351#4093840 <https://reviews.llvm.org/D124351#4093840>, @nikic wrote:
>
>> FYI this causes a minor compile-time regression (around 0.35% on 7zip at `O0`): http://llvm-compile-time-tracker.com/compare.php?from=cd173cbd7cca69c29df42cd4b42e60433435c29b&to=d708a186b6a9b050d09558163dd353d9f738c82d&stat=instructions%3Au
>>
>> Just wanted to check whether that's expected.
>
> It's certainly not great but not entirely unexpected as we are doing quite a bit more work, although it should only affect code that constructs a lot of distinct lambda.

Does 7zip meet that criteria? As a gut-check that this only costs in that case, would be nice to know if the 7zip regression is that case, or is this the cost even when that isn't true - so we could expect higher costs when it is true?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124351/new/

https://reviews.llvm.org/D124351