[PATCH] D143053: [C++20] [Modules] Pop Expression Evaluation Context when we skip its body during parsing

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 1 09:35:29 PST 2023


cor3ntin added inline comments.


================
Comment at: clang/lib/Parse/Parser.cpp:1415
+    //
+    // FIXME: It looks not easy to balance PushExpressionEvaluationContext()
+    // and PopExpressionEvaluationContext().
----------------
shafik wrote:
> It does seem a bit ad-hoc
could we use `ExitFunctionBodyRAII` here, maybe ? It already deals with lambdas


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143053/new/

https://reviews.llvm.org/D143053



More information about the cfe-commits mailing list