[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

Wed Feb 1 08:01:46 PST 2023

clementval added a comment.

In D142244#4096648 <https://reviews.llvm.org/D142244#4096648>, @jsjodin wrote:

> In D142244#4096579 <https://reviews.llvm.org/D142244#4096579>, @clementval wrote:
>
>> In D142244#4096546 <https://reviews.llvm.org/D142244#4096546>, @jsjodin wrote:
>>
>>> In D142244#4096538 <https://reviews.llvm.org/D142244#4096538>, @clementval wrote:
>>>
>>>> In D142244#4096512 <https://reviews.llvm.org/D142244#4096512>, @jsjodin wrote:
>>>>
>>>>> No, it should work for any configuration as far as I know. How are you running the test?
>>>>
>>>> Just with `check-flang`
>>>
>>> How does it fail? Can you show the output? Also what CPU are you running on?
>>
>>
>>
>>   I run on `x86_64`
>
> How did you configure your build? I'd like to reproduce your build and see if I can make it fail on my machine. Right now the test passes.

My bad .. my `CompilerInvocation.cpp` was overwritten and missed part of this patch. It works fine. Sorry to have bothered you with that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142244/new/

https://reviews.llvm.org/D142244