[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

[Valentin Clement via Phabricator via cfe-commits]

clementval added a comment.

In D142244#4096546 <https://reviews.llvm.org/D142244#4096546>, @jsjodin wrote:

> In D142244#4096538 <https://reviews.llvm.org/D142244#4096538>, @clementval wrote:
>
>> In D142244#4096512 <https://reviews.llvm.org/D142244#4096512>, @jsjodin wrote:
>>
>>> No, it should work for any configuration as far as I know. How are you running the test?
>>
>> Just with `check-flang`
>
> How does it fail? Can you show the output? Also what CPU are you running on?



  ********************
  FAIL: Flang :: Driver/embed.f90 (2 of 1993)
  ******************** TEST 'Flang :: Driver/embed.f90' FAILED ********************
  Script:
  --
  : 'RUN: at line 6';   llvm-project/build/bin/flang-new -fc1 -emit-llvm -o - -fembed-offload-object=llvm-project/flang/test/Driver/Inputs/hello.f90 llvm-project/flang/test/Driver/embed.f90 2>&1 | llvm-project/build/bin/FileCheck llvm-project/flang/test/Driver/embed.f90
  : 'RUN: at line 8';   llvm-project/build/bin/flang-new -fc1 -emit-llvm-bc -o llvm-project/build/tools/flang/test/Driver/Output/embed.f90.tmp.bc llvm-project/flang/test/Driver/embed.f90 2>&1
  : 'RUN: at line 9';   llvm-project/build/bin/flang-new -fc1 -emit-llvm -o - -fembed-offload-object=llvm-project/flang/test/Driver/Inputs/hello.f90 llvm-project/build/tools/flang/test/Driver/Output/embed.f90.tmp.bc 2>&1 | llvm-project/build/bin/FileCheck llvm-project/flang/test/Driver/embed.f90
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  llvm-project/flang/test/Driver/embed.f90:11:10: error: CHECK: expected string not found in input
  ! CHECK: @[[OBJECT_1:.+]] = private constant [61 x i8] c"program hello\0A write(*,*), \22Hello world!\22\0Aend program hello\0A", section ".llvm.offloading", align 8, !exclude !0
           ^
  <stdin>:1:1: note: scanning from here
  ; ModuleID = 'FIRModule'
  ^
  
  Input file: <stdin>
  Check file: llvm-project/flang/test/Driver/embed.f90
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
            1: ; ModuleID = 'FIRModule' 
  check:11     X~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2: source_filename = "FIRModule" 
  check:11     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            3: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" 
  check:11     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            4: target triple = "x86_64-unknown-linux-gnu" 
  check:11     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            5:  
  check:11     ~
            6: @_QFECi = internal constant i32 1 
  check:11     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            .
            .
            .
  >>>>>>



  `
  FAIL: Flang :: Driver/embed-error.f90 (1 of 1993)
  ******************** TEST 'Flang :: Driver/embed-error.f90' FAILED ********************
  Script:
  --
  : 'RUN: at line 6';   not llvm-project/build/bin/flang-new -fc1 -emit-llvm -o - -fembed-offload-object=llvm-project/flang/test/Driver/Inputs/missing.f90 llvm-project/flang/test/Driver/embed-error.f90 2>&1 | llvm-project/build/bin/FileCheck llvm-project/flang/test/Driver/embed-error.f90 --check-prefix=ERROR
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  llvm-project/flang/test/Driver/embed-error.f90:8:10: error: ERROR: expected string not found in input
  ! ERROR: error: could not open
           ^
  <stdin>:1:1: note: scanning from here
  ; ModuleID = 'FIRModule'
  ^
  <stdin>:6:14: note: possible intended match here
  @_QFECi = internal constant i32 1
               ^
  
  Input file: <stdin>
  Check file: llvm-project/flang/test/Driver/embed-error.f90
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
             1: ; ModuleID = 'FIRModule' 
  check:8'0     X~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
             2: source_filename = "FIRModule" 
  check:8'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             3: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" 
  check:8'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             4: target triple = "x86_64-unknown-linux-gnu" 
  check:8'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             5:  
  check:8'0     ~
             6: @_QFECi = internal constant i32 1 
  check:8'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  check:8'1                  ?                     possible intended match
             7: @_QQEnvironmentDefaults = constant ptr null 
  check:8'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             8:  
  check:8'0     ~
             9: declare ptr @malloc(i64) 
  check:8'0     ~~~~~~~~~~~~~~~~~~~~~~~~~
            10:  
  check:8'0     ~
            11: declare void @free(ptr) 
  check:8'0     ~~~~~~~~~~~~~~~~~~~~~~~~
             .
             .
             .

I run on `x86_64`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142244/new/

https://reviews.llvm.org/D142244