[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 1 06:22:15 PST 2023
ABataev added inline comments.
================
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:496
+def err_destroy_clause_without_argument
+ : Error<"'destroy' clause without argument on '#pragma omp depobj' "
----------------
1. Usually we name them err_omp_... Also, move to other err_omp messages.
2. Better to use something like "Expected depobj with argument if destroy clause is specified" or something like this.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:17666
+ if (!InteropVar && (LangOpts.OpenMP >= 52 &&
+ DSAStack->getCurrentDirective() == OMPD_depobj)) {
+ Diag(StartLoc, diag::err_destroy_clause_without_argument);
----------------
Can it be used with any other directive except for depobj?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143021/new/
https://reviews.llvm.org/D143021
More information about the cfe-commits
mailing list