[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 1 05:31:52 PST 2023


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/ConfigFragment.h:243
+    /// - Strict
+    std::optional<Located<std::string>> Mode;
+
----------------
I think "Diagnostics.Mode" is too vague a name.

I expect this to be a rollout flag that we remove in the medium term (either deciding to stick to the old or new behavior), so maybe something ultra-specific like`AllowStalePreamble: yes/no`?
(Preamble is jargon, maybe there's something better, but again I don't think we should plan for this to be really "user-visible")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142890/new/

https://reviews.llvm.org/D142890



More information about the cfe-commits mailing list