[PATCH] D142932: Multilib YAML parsing

[Mikhail Maltsev via Phabricator via cfe-commits]

miyuki added inline comments.


================
Comment at: clang/lib/Driver/Multilib.cpp:83
+    const std::regex Regex(M.Regex);
+    if (std::find_if(InFlags.begin(), InFlags.end(),
+                     [&Regex](const std::string &F) {
----------------
Please use `llvm::find_if(InFlags, ...)`


================
Comment at: clang/lib/Driver/Multilib.cpp:153
+  static std::string validate(IO &io, MultilibFlagMap::Matcher &M) {
+    if (M.MatchFlags.empty() && M.NoMatchFlags.empty())
+      return "value required for 'matchFlags' or 'noMatchFlags'";
----------------
I think it would make sense to validate regular expression syntax as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142932/new/

https://reviews.llvm.org/D142932