[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

[David Spickett via Phabricator via cfe-commits]

DavidSpickett added a comment.

On AArch64 we have the following failures:

  Failed Tests (15):
    Clang :: CXX/basic/basic.stc/basic.stc.dynamic/p2-nodef.cpp
    Clang :: CodeCompletion/ordinary-name-cxx11.cpp
    Clang :: CodeCompletion/ordinary-name.cpp
    Clang :: CodeGenCXX/cxx20-module-std-subst-2b.cpp
    Clang :: CodeGenCXX/cxx20-module-std-subst-2c.cpp
    Clang :: Index/complete-preamble.cpp
    Clang :: Index/load-namespaces.cpp
    Clang :: Modules/implicit-declared-allocation-functions.cppm
    Clang :: PCH/chain-friend-instantiation.cpp
    Clang :: PCH/cxx1z-aligned-alloc.cpp
    Clang :: SemaCXX/constructor-initializer.cpp
    Clang :: SemaCXX/using-directive.cpp
    Clang-Unit :: AST/./ASTTests/ParameterizedTests/DeclContextTest/removeDeclOfClassTemplateSpecialization/0
    Clang-Unit :: StaticAnalyzer/./StaticAnalysisTests/CallDescription/RejectOverQualifiedNames
    Clang-Unit :: StaticAnalyzer/./StaticAnalysisTests/CallDescription/SkipAnonimousNamespaces

None of which are caused by assertions but instead errors of the form:

  input.cc:12:7: error: reference to 'std' is ambiguous
        std::container v;
        ^
  note: candidate found by name lookup is 'std'
  input.cc:3:15: note: candidate found by name lookup is 'my::std'
      namespace std {
                ^
  1 error generated.

  /home/david.spickett/llvm-project/clang/test/CodeGenCXX/cxx20-module-std-subst-2b.cpp:14:18: error: reference to 'std' is ambiguous
  void f(str<char, std::char_traits<char>> &s) {
                   ^
  /home/david.spickett/llvm-project/clang/test/CodeGenCXX/cxx20-module-std-subst-2b.cpp:7:11: note: candidate found by name lookup is 'std'
  namespace std {
            ^

On Arm it's the exact same set of failures.

What would help you debug those? I don't know the background for the change but I can check specifics on the machine itself if needed.

Test log from AArch64: F26314570: tests.log <https://reviews.llvm.org/F26314570>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142822/new/

https://reviews.llvm.org/D142822