[PATCH] D142999: [Clang] Adjust PIC handling for the AMDGPU ToolChain

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 31 11:20:29 PST 2023


jhuber6 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.h:71
   }
-  bool isPICDefaultForced() const override { return false; }
+  bool isPICDefaultForced() const override { return true; }
   bool SupportsProfiling() const override { return false; }
----------------
arsenm wrote:
> What's the difference between isPICDefault and isPICDefaultForced?
`isPICDefaultForced` more or less just overrides `-fpie` or similar AFAIK.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142999/new/

https://reviews.llvm.org/D142999



More information about the cfe-commits mailing list