[PATCH] D142999: [Clang] Adjust PIC handling for the AMDGPU ToolChain

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 31 11:02:11 PST 2023


jhuber6 created this revision.
jhuber6 added reviewers: arsenm, JonChesterfield, yaxunl, t-tye, msearles.
Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, wdng.
Herald added a project: clang.

The AMDGPU target only emits shared libraries currently. This patch
changes the handling of the PIC level to be managed in the
AMDGPUToolChain rather than having a special case for it. This causes
`--target=amdgcn--` to no longer set the PIC. This should be an
acceptable change since that doesn't use a correct toolchain anyway.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142999

Files:
  clang/lib/Driver/ToolChains/AMDGPU.cpp
  clang/lib/Driver/ToolChains/AMDGPU.h
  clang/lib/Driver/ToolChains/CommonArgs.cpp
  clang/lib/Driver/ToolChains/HIPAMD.cpp
  clang/test/Driver/amdgcn-toolchain-pic.cl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142999.493678.patch
Type: text/x-patch
Size: 3841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230131/e9f29202/attachment.bin>


More information about the cfe-commits mailing list