[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

[Artem Belevich via Phabricator via cfe-commits]

tra added a comment.

LGTM for the parts I've commented on.



================
Comment at: clang/test/CodeGenCUDA/link-builtin-bitcode-denormal-fp-mode.cu:77
+
+// CHECK: kernel_f32({{.*}}) #[[$KERNELATTR:[0-9]+]]
+__global__ void kernel_f32(float* out, float* a, float* b, float* c) {
----------------
arsenm wrote:
> tra wrote:
> > Nit: CHECK-LABEL ?
>  error: found 'CHECK-LABEL:' with variable definition or use
> 
Interesting. 
In that case label and attribute checks could be separated into something like this:
```
CHECK-LABEL: name
CHECK-SAME: [[attribute]]
```

Up to you.


================
Comment at: llvm/test/CodeGen/Generic/denormal-fp-math-cl-opt.ll:3
+
+; Check that we annotated the command line flag annotates the IR with the appropriate attributes
+
----------------
tra wrote:
> Edit: `Check that the command line flag annotates the IR with the appropriate attributes.`
^^ The comment still needs to be edited.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142907/new/

https://reviews.llvm.org/D142907