[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

Steven Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 31 09:49:46 PST 2023


srj added a comment.

In D141861#4094059 <https://reviews.llvm.org/D141861#4094059>, @jhuber6 wrote:

> In D141861#4094058 <https://reviews.llvm.org/D141861#4094058>, @srj wrote:
>
>> In D141861#4094043 <https://reviews.llvm.org/D141861#4094043>, @jhuber6 wrote:
>>
>>> Would this just require checking `LLVM_BUILD_32_BITS`? Should be an easy change.
>>
>> I think so. (It might be tempting to check `if (CMAKE_SIZEOF_VOID_P EQUAL 8)` but LLVM_BUILD_32_BITS is likely to be a more explicit signal.)
>
> SG, want me to push that real quick?

Yes please!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141861/new/

https://reviews.llvm.org/D141861



More information about the cfe-commits mailing list