[PATCH] D139926: [clangd] Add semantic token for angle brackets

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

Thanks for the updates!

In D139926#4064769 <https://reviews.llvm.org/D139926#4064769>, @kadircet wrote:

> LMK if you're going to take a look at the implementation @nridge, otherwise I am happy to do that as well.

The implementation looks good to me now. (I admit I don't have a high level of confidence in my understanding of the SourceLocation stuff in the implementation of `addAngleBracketTokens()`, but it sounds like you've looked at that).

I'll leave final approval to you @kadircet in case you have any remaining comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139926/new/

https://reviews.llvm.org/D139926