[PATCH] D141861: [nvptx-arch] Dynamically load the CUDA runtime if not found during the build

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 30 11:10:18 PST 2023


jhuber6 added a comment.

In D141861#4091408 <https://reviews.llvm.org/D141861#4091408>, @srj wrote:

> In D141861#4091403 <https://reviews.llvm.org/D141861#4091403>, @jhuber6 wrote:
>
>> In D141861#4091383 <https://reviews.llvm.org/D141861#4091383>, @srj wrote:
>>
>>> It looks like this change (but not the rG4ce454c654bd <https://reviews.llvm.org/rG4ce454c654bd4e027fbdcd7b1dba9d164cd36463>) is in the 17 branch, as the latter is now failing in the same way for crosscompiles.
>>
>> It looks like it's there for me, see https://github.com/llvm/llvm-project/blob/main/clang/tools/nvptx-arch/NVPTXArch.cpp#L20. What is the issue? I made a slight tweak a few days ago on the 17 branch that updated how we could the CUDA driver.
>
> We just started testing with the 17 branch this morning, can you point me at your tweak?

https://github.com/llvm/llvm-project/commit/759dec253695f38a101c74905c819ea47392e515. Does it work if you revert this? I wouldn't think it wouldn't affect anything. That's the only change that happened after the 16 release as far as I'm aware.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141861/new/

https://reviews.llvm.org/D141861



More information about the cfe-commits mailing list