[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 30 07:40:18 PST 2023


arsenm added inline comments.


================
Comment at: clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel.cl:381
+// GFX900-LABEL: define {{[^@]+}}@callee
+// GFX900-SAME: (i64 noundef [[ID:%.*]], ptr addrspace(1) noundef [[OUT:%.*]]) #[[ATTR1:[0-9]+]] {
+// GFX900-NEXT:  entry:
----------------
yaxunl wrote:
> these attributes are not really checked since ATTR1 etc are not used to check the attributes definitions. Is this a bug of update_cc_test_checks.py ? Or it is expected to be manually edited to enforce the checking?
Seems to be an update_cc_test_checks bug I mentioned in the description 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141620/new/

https://reviews.llvm.org/D141620



More information about the cfe-commits mailing list