[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 29 22:32:01 PST 2023


kadircet added a subscriber: VitaNuo.
kadircet added a comment.

thanks a lot for the patch, we're already having some efforts right now to improve our cppreference parsing and get to a more complete set of symbols (@VitaNuo for visibility, who drives these efforts).

Regarding the experimental symbols, first of all I am not sure if it's a good idea to include them in clangd (or other clang-tools) at all. As a clang-tool binary can stay around for years (e.g. people can use 3 years old clangd) and symbols under `std::experimental` are subject to change throughout that period, hence the information provided is going to be vastly different than what the truth is in that time window (also i don't know if they'll be "same" across libc++ vs libstdc++ implementations).
In addition to that, AFAICT there's no great index page to parse for technical-specs hence we might indeed be forced to manually curate these symbols and that's something we've been trying to avoid due to maintenance costs. In the case of technical-specs this cost will increase, because they're subject to change a lot more frequent than regular std symbols and value is even less as these are not used by majority of the developers.

So I am afraid this is not some extra complexity we can take in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142836/new/

https://reviews.llvm.org/D142836



More information about the cfe-commits mailing list