[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.

LGTM overall. Thanks for the patch. Others feel free to comment.



================
Comment at: clang/lib/Driver/Driver.cpp:4214
   }
-
+  // Call validator for dxil when -Vd not in Args.
+  if (C.getDefaultToolChain().getTriple().isDXIL()) {
----------------
Extreme nit. whitespace above.


================
Comment at: clang/test/Driver/dxc_dxv_path.hlsl:7
+// RUN: echo "dxv" > %T/dxv && chmod 754 %T/dxv && %clang_dxc --dxv-path=%T %s -Tlib_6_3 -### 2>&1 | FileCheck %s --check-prefix=DXV_PATH
+// DXV_PATH:dxv" "-" "-o" "-"
+
----------------
Would this be called `dxv.exe` on Windows?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141705/new/

https://reviews.llvm.org/D141705