[PATCH] D142780: [clang] NFCI: Use FileEntryRef in FileManager's UID mapping

Richard Howell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 27 14:17:26 PST 2023


rmaz added a comment.

In D142780#4087270 <https://reviews.llvm.org/D142780#4087270>, @benlangmuir wrote:

> If compiling a single pcm accesses multiple hard links with the same UID, then it would not be possible to use the set of UIDs to get the "right path".  At best we could make it get a deterministic path -- e.g. if we tracked the order of access.

With you so far. Is there a reason we need to use the UIDs in this case? Would it be possible to refactor `GetUniqueIDMapping` to instead populate an array with all the `FileEntryRef`s that had been seen and serialize that instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142780/new/

https://reviews.llvm.org/D142780



More information about the cfe-commits mailing list