[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

Fri Jan 27 08:56:00 PST 2023

KyleFromKitware added a comment.

In D142673#4086018 <https://reviews.llvm.org/D142673#4086018>, @carlosgalvezp wrote:

> Note: I do not have possibility to add code comments - is there some too strict permissions set for this patch? It has not happened to other patches.

I accidentally set the permissions too strict, I've fixed it here and on all my other diffs.

> I think the design choice in clang-tidy is that checks from different modules should not depend on each other like this, that's why a common `utils` folder exists.
> What is the difference between `llvm-header-guard` and `readability-header-guard`? Could one be the alias of the other, possibly with some added configuration options?

See the discussion in D142123 <https://reviews.llvm.org/D142123>. We decided it would be best to have a single `readability-header-guard` which can select one of several different styles. `llvm-header-guard` temporarily exists as a deprecated alias to `readability-header-guard` with the `llvm` style selected, and will be removed in a future version.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142673/new/

https://reviews.llvm.org/D142673