[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 27 08:49:07 PST 2023


carlosgalvezp added a comment.

Note: I do not have possibility to add code comments - is there some too strict permissions set for this patch? It has not happened to other patches.

Review comment:

I think the design choice in clang-tidy is that checks from different modules should not depend on each other like this, that's why a common `utils` folder exists.
What is the difference between `llvm-header-guard` and `readability-header-guard`? Could one be the alias of the other, possibly with some added configuration options?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142673/new/

https://reviews.llvm.org/D142673



More information about the cfe-commits mailing list