[PATCH] D142723: [C2x] Stop diagnosing member and array access in offsetof as an extension

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 27 07:04:58 PST 2023


aaron.ballman created this revision.
aaron.ballman added reviewers: erichkeane, clang-language-wg, jyknight.
Herald added a project: All.
aaron.ballman requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This was a mistake from e7300e75b51a7e7d4e81975b4be7a6c65f9a8286 <https://reviews.llvm.org/rGe7300e75b51a7e7d4e81975b4be7a6c65f9a8286> (https://reviews.llvm.org/D133574) caused by us accidentally tracking an older copy of the C DR list for DR496. The text in https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2396.htm#dr_496 makes it clear that subobjects are allowed, which means member and array access expressions are allowed.

This backs out the changes from the previous commit that relate to this diagnostic.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142723

Files:
  clang/docs/LanguageExtensions.rst
  clang/include/clang/Basic/DiagnosticParseKinds.td
  clang/lib/Parse/ParseExpr.cpp
  clang/test/C/C2x/n2350.c
  clang/test/C/drs/dr4xx.c
  clang/test/CXX/drs/dr4xx.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142723.492748.patch
Type: text/x-patch
Size: 6789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230127/c80c3ad4/attachment.bin>


More information about the cfe-commits mailing list