[PATCH] D142655: [WIP][clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 26 23:48:37 PST 2023


carlosgalvezp added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:149
+  Options.HeaderFileExtensions = {"", "h", "hh", "hpp", "hxx"};
+  Options.ImplementationFileExtensions = {"c", "cc", "cpp", "cxx"};
   Options.HeaderFilterRegex = "";
----------------
ClockMan wrote:
> what about .c++ ? like file.c++ for implementation and h++ for header.
> Its listed on https://en.wikibooks.org/wiki/C%2B%2B_Programming/Programming_Languages/C%2B%2B/Code/File_Organization
> 
> I know that probably no-one uses them, but who knows.
First time I've seen it! If someone uses them they can add it in their config file, which is the purpose of this option :)

Anyhow the scope of this patch is not add new functionality, simply move the configuration from local to global options. I plan to add more default extensions (cuda, objc) in a follow up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142655/new/

https://reviews.llvm.org/D142655



More information about the cfe-commits mailing list