[PATCH] D139926: [clangd] Add semantic token for angle brackets

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 26 23:44:12 PST 2023


nridge added a comment.

In D139926#4076652 <https://reviews.llvm.org/D139926#4076652>, @ckandeler wrote:

> Thanks for the test cases!
> All fixed, except:
>
>> // variable template specialization
>> // parameter and argument lists are missing semantic tokens
>> template <>
>> constexpr int V<int> = 5;
>
> Argument list fixed. I didn't manage to make the parameter list work.

Thanks! That one remaining case seems to be a bug in the AST, I investigated it a bit and posted a fix at D142692 <https://reviews.llvm.org/D142692>. It should make your code work without further modification (the missing template parameter list will start showing up in `VarTemplateSpecializationDecl::getNumTemplateParameterLists()`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139926/new/

https://reviews.llvm.org/D139926



More information about the cfe-commits mailing list