[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

Thu Jan 26 18:05:24 PST 2023

jrtc27 added a comment.

In D136886#4083762 <https://reviews.llvm.org/D136886#4083762>, @vabridgers wrote:

> It appears to me this change https://reviews.llvm.org/D116774 is responsible for the unexpected behavior. Question for @jrtc27 : do you think if we could make this change consistent with https://reviews.llvm.org/D116774 that the problem would be addressed? Looks like we could make consistent changes in Sema.cpp and perhaps the problem would be addressed?
>
> I'm assuming that keeping __va_list in std for aarch6 and arm is a requirement for the abi and not open to change?
> Best

I don't understand the question. __va_list needs to be in std on C++ aarch64/arm as that's part of the ABI. __va_list cannot be in std on C aarch64/arm as namespaces do not exist in C and having the AST say they do causes all manner of problems (as outlined in my prior comments on those revisions).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136886/new/

https://reviews.llvm.org/D136886