[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

[Xiang Li via Phabricator via cfe-commits]

python3kgae marked 2 inline comments as done.
python3kgae added a comment.

In D141705#4082935 <https://reviews.llvm.org/D141705#4082935>, @jhuber6 wrote:

> I'm not overly familiar with HLSL or DirectX here. Most of the changes are purely mechanical, but I don't see anywhere we create the tool. Does that come later? Normally you'd test these with `-ccc-print-bindings`, `-ccc-print-bindings`, and `-###`.

The tool ('dxv') is not included in hlsl compiler release yet. It will come later.
Added test with ccc-print-bindings.



================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687
+def warn_drv_dxc_missing_dxv : Warning<"dxv not found."
+    " Resulting DXIL will not be signed for use in release environments.">;
 
----------------
beanz wrote:
> Not all `dxv` binaries can sign… some just validate. Only the “official” releases support signing.
Fixed.


================
Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:146-147
+    // Not find dxv.
+    C.getDriver().Diag(diag::warn_drv_dxc_missing_dxv);
+    return;
+  }
----------------
jhuber6 wrote:
> Can we really just ignore this if we don't find the path? Normally this is a hard error. If this is purely optional I would probably suggest not creating the job in the first place.
This is optional.
I'll move the check when create the job.


================
Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:174
+    // Lookup binaries into the driver directory, this is used to
+    // discover the clang-offload-bundler executable.
+    getProgramPaths().push_back(getDriver().Dir);
----------------
jhuber6 wrote:
> Copy paste.
Good catch.
Fixed.


================
Comment at: clang/test/Misc/warning-flags.c:19
 
 The list of warnings below should NEVER grow.  It should gradually shrink to 0.
 
----------------
jhuber6 wrote:
> This comment looks relevant.
Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141705/new/

https://reviews.llvm.org/D141705